Bugfix/66 graceful crash handling #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssemblyJohn
requested review from
corneliusclaussen,
SebaLukas,
Pietfried and
hikinggrass
as code owners
AssemblyJohn
force-pushed
the
bugfix/66-graceful-crash-handling
branch
from
420286e to
08b5c7a
Compare
Pietfried
requested changes
May 5, 2024
| description: OCSP data related to requested the certificates | ||
| type: object | ||
| required: | ||
| - hash |
There was a problem hiding this comment.
Why is the ocsp_path optional?
There was a problem hiding this comment.
Because if we have a chain of returned certificates, for example leaf<-subca2<-subca1, we agreed that a list of the same count of OCSP data will be returned, because matching the ocsp data to a certificate in everest-core will be very difficult, based on a certificate hash, because it is difficult to build that has, especially when intermediaries are involved. So, if a chain of 3 certificates is returned, then a vector of 3 ocsp data is returned, each matched to the certificate from the chain in order.
3 tasks
|
Some comments resolved, awaiting further feedback. |
AssemblyJohn
requested review from
SirVer,
golovasteek and
dorezyuk
as code owners
AssemblyJohn
force-pushed
the
bugfix/66-graceful-crash-handling
branch
from
c5d6f37 to
db49018
Compare
Pietfried
reviewed
May 7, 2024
AssemblyJohn
force-pushed
the
bugfix/66-graceful-crash-handling
branch
2 times, most recently
from
f4c0c59 to
72d1f8c
Compare
SirVer
approved these changes
May 7, 2024
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
bugfix/66-graceful-crash-handling
branch
from
4229a94 to
5b2a238
Compare
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Pietfried
approved these changes
May 10, 2024
| @@ -146,10 +157,13 @@ cmds: | |||
| description: Specifies the encoding of the key | |||
| type: string | |||
| $ref: /evse_security#/EncodingFormat | |||
| include_ocsp: | |||
| description: Specifies whether per-certificate OCSP data is also requested | |||
There was a problem hiding this comment.
Suggested change
| description: Specifies whether per-certificate OCSP data is also requested | |
| description: Specifies whether per-certificate OCSP data is also requested |
hikinggrass
added a commit
that referenced
this pull request
May 10, 2024
When #665 was merged it did not point to git hashes on the main branch but on a now deleted feature branches
3 tasks
hikinggrass
added a commit
that referenced
this pull request
May 10, 2024
When #665 was merged it did not point to git hashes on the main branch but on a now deleted feature branches Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
added a commit
that referenced
this pull request
May 10, 2024
When #665 was merged it did not point to git hashes on the main branch but on a now deleted feature branches Signed-off-by: Kai-Uwe Hermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updated interface usage for CSR generation
Issue ticket number and link
EVerest/libocpp#604
EVerest/libevse-security#70
Checklist before requesting a review